[Webkit-unassigned] [Bug 150642] [GTK] Use CROSS_PLATFORM_CONTEXT_MENUS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 08:41:13 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=150642

--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Stock items don't matter much if you like them, it just looked like an easy cleanup to me.

(In reply to comment #5)
> Last time I checked it was not that easy, it would probably require a glib
> version bump to ensure it does everything we need, and it affects the public
> API. So, I don't see the point, GtkAction works very well for us.

For Epiphany, we will need to use GAction and GMenuModel to get can get a popover menu button. We could use GAction for that and GtkAction for the context menus, but that would be messy, and GtkAction is confusing and not used elsewhere in GNOME anymore, so we don't want to.

Basically, I want the ability to create WebKitContextMenuItems based on GActions rather than GtkActions. I am hoping the implementation could be layered on top of the current GtkAction implementation; the goal is to ensure the client doesn't have to use confusing GtkAction, but of course we have to in WebKit. Something I'll look into eventually, so don't worry if you don't want to work on it yourself; I just brought it up since you've clearly spent quite some time with the context menus recently, and you understand GtkAction. Anyway, it's outside the scope of this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151105/e2dcba48/attachment-0001.html>


More information about the webkit-unassigned mailing list