[Webkit-unassigned] [Bug 144938] WebCrypto: RSASSA-PKCS1-v1_5 generated keys can not be exported

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144938

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264838|review?                     |review-
              Flags|                            |

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 264838
  --> https://bugs.webkit.org/attachment.cgi?id=264838
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264838&action=review

The approach looks good to me, however EWS detects crashes (assertion failures?)

> Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:181
> +    if (!getHashAlgorithm(jsDictionary, result->hash, true)) {

We try very hard to not have mysterious true/false arguments in new code. Please add either an enum class for the value, or a separate function.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151105/7a9a8c00/attachment.html>