[Webkit-unassigned] [Bug 150740] Link preview doesn't work on XHTML pages with Content-Type header as `application/xhtml+xml`

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 08:41:09 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=150740

--- Comment #17 from Darin Adler <darin at apple.com> ---
(In reply to comment #16)
> Maybe clickableElement should be a bool too.

Yes, I think that’s the answer. We should change it from a string to a bool.

Everything you are saying makes sense. As far as I can tell from what you say, there’s no incorrect behavior in the code as it stands. But it’s not valuable to send over a name to simply convey the boolean “is a clickable element” state. I don’t think there’s anything correct we could do with the name alone other than check it for null/empty. Just temptation to use it incorrectly for future programmers!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151104/8db5e110/attachment.html>


More information about the webkit-unassigned mailing list