[Webkit-unassigned] [Bug 150836] [GStreamer] Use RunLoop::Timer for ready state timer in MediaPlayerPrivateGStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150836

--- Comment #6 from Philippe Normand <pnormand at igalia.com> ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (In reply to comment #2)
> > > > Comment on attachment 264690 [details]
> > > > Patch
> > > > 
> > > > View in context:
> > > > https://bugs.webkit.org/attachment.cgi?id=264690&action=review
> > > > 
> > > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:208
> > > > > +#if PLATFORM(GTK)
> > > > 
> > > > Why not USE(GLIB) ?
> > > 
> > > Because EFL doesn't support it
> > 
> > But aren't they using Glib? If not it's quite silly because quite a few deps
> > like GStreamer and libsoup have an implicit dependency on it already.
> 
> They don't use glib sources in the RunLoop implementation and win cairo
> either. See how setPriority is defined in RunLoop.h
> 
> #if USE(GLIB) && !PLATFORM(EFL)
>         void setPriority(int);
> #endif
> 
> EFL has its own implementation of RunLoop and RunLoop::Timer using ecore.

Alright :) So let's use the same ifdef as above for consistency then?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151104/f9927136/attachment.html>