[Webkit-unassigned] [Bug 150807] [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150807

--- Comment #9 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 264681
  --> https://bugs.webkit.org/attachment.cgi?id=264681
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264681&action=review

>>> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:92
>>> +        LockHolder locker(m_sampleMutex);
>> 
>> I'm still stuck on this. in requestRender() m_timer operation is protected, here it's not.
>> 
>> Regarding previous behavior, timeoutSource was never cancelled after scheduling, except when WebKitVideoSinkPrivate was destroyed. This technically deviates from that.
> 
> It's not actually the timer what is protected, but the sample, we need to hold the lock for the condition wait.

The timer is protected in requestRender(), and I don't see any reason why it wouldn't be protected here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151104/ec8df2b7/attachment.html>