[Webkit-unassigned] [Bug 150693] Tapping and holding a link should have a share option

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150693

Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #9 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #8)
> Comment on attachment 264406 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264406&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3388
> > +        [_textSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect];
> > +    else if (_webSelectionAssistant && [_webSelectionAssistant respondsToSelector:@selector(showShareSheetFor:fromRect:)])
> > +        [_webSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect];
> 
> Do these strings get interpreted as URLs by some code on the other side of
> this API, or do they end up being presented to the user? If it’s the latter,
> then we shouldn’t use -absoluteString, because it doesn’t give a good
> representation of certain URLs, such as ones with non-ASCII characters in
> the host or the path. Instead, -_web_userVisibleString should work. If these
> strings do get turned back into URLs, and we can’t use an alternative API
> that takes NSURLs, then we should consider using -_web_originalDataAsString
> here and the reverse transformation on the receiving end.
> 
> >> Source/WebKit2/UIProcess/ios/WKPDFView.mm:727
> >> +        [_webSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect];
> > 
> > url.absoluteString (and above too)
> 
> Same comment here.

Thank you Dan! This is presented to the user, and I was able to see the bug you referred to with non-ascii URLs. I will attach a follow-up patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151102/85878425/attachment.html>