[Webkit-unassigned] [Bug 150770] [GTK] Use RunLoop in WorkQueue implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150770

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264509|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 264509
  --> https://bugs.webkit.org/attachment.cgi?id=264509
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264509&action=review

> Source/WTF/wtf/WorkQueue.h:43
> +#include <wtf/RunLoop.h>

Do we actually need this header to be included? Can we just forward-declare RunLoop? This header doesn’t actually depend on the content of RunLoop, just that it’s a pointer to some class.

> Source/WTF/wtf/WorkQueue.h:113
> +    RunLoop* m_runLoop;

Would be nice if we could find a way to make this a reference rather than a pointer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151101/1663cb77/attachment.html>