[Webkit-unassigned] [Bug 145457] [EFL] Jpeg image export implementation for Canvas.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145457

--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 253960
  --> https://bugs.webkit.org/attachment.cgi?id=253960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253960&action=review

> Source/WebCore/ChangeLog:20
> +        * platform/image-encoders/JPEGImageEncoder.cpp:

You need to explain what is modified.

> Source/WebCore/platform/MIMETypeRegistry.cpp:270
> +#elif PLATFORM(EFL)

Why can't we support image/tiff, image/bmp, image/ico ?

Besides I think GTK and EFL have used cairo backend. Thus it might be good if you change this change as below,

 #elif PLATFORM(GTK)
-    supportedImageMIMETypesForEncoding->add("image/png");
-    supportedImageMIMETypesForEncoding->add("image/jpeg");
     supportedImageMIMETypesForEncoding->add("image/tiff");
     supportedImageMIMETypesForEncoding->add("image/bmp");
     supportedImageMIMETypesForEncoding->add("image/ico");
 #elif USE(CAIRO)
     supportedImageMIMETypesForEncoding->add("image/png");
+    supportedImageMIMETypesForEncoding->add("image/jpeg");
+    supportedImageMIMETypesForEncoding->add("image/png");
 #endif

> Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:4
> + *  This library is free software; you can redistribute it and/or

Oops. LGPL.... Please use BSD !

> Source/WebCore/platform/image-encoders/JPEGImageEncoder.cpp:126
> +        for (const unsigned char* rowEnd = pixel + offset + compressData.image_width * 4; pixel + offset < rowEnd;) {

I think this change can influence on other ports. So you need to explain why you modify this code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150601/2e60591f/attachment.html>