[Webkit-unassigned] [Bug 90906] Implement ECMAScript Internationalization API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90906

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253799|review?                     |review-
              Flags|                            |

--- Comment #20 from Darin Adler <darin at apple.com> ---
Comment on attachment 253799
  --> https://bugs.webkit.org/attachment.cgi?id=253799
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253799&action=review

review- because EWS shows this is not complying on iOS or Mac yet; didn’t review in detail

> Source/JavaScriptCore/icu/unicode/bytestream.h:48
> +class U_COMMON_API ByteSink : public UMemory {

Please don’t add ICU headers for ICU’s C++ classes to the project. We cannot create a dependency on ICU’s C++ API; unlike the ICU C API it’s not guaranteed compatible across versions of the ICU framework.

> Source/JavaScriptCore/icu/unicode/uobject.h:101
> +class U_COMMON_API UMemory {

Pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150529/cd009f01/attachment-0001.html>