[Webkit-unassigned] [Bug 143164] Web Inspector: REGRESSION(r179286) Editing Style Metrics Values no longer works

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143164

--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
(In reply to comment #3)
> Comment on attachment 253801 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253801&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js:425
> > +            function didToggle()
> 
> Reading the callback code, this will get called even if there was an error
> in the backend (passed: error, result, wasThrown). Should it only update if
> something actually changed?

I thought about doing a "style.getPropertyValue" and seeing if the value changed, but decided against it.

Unknown side effects / errors could happen if someone overrides `CSSStyleDeclaration.prototype.setProperty` and ultimately still could have changed the property and so a refresh would still be useful. Always doing a refresh is the safe bet as long as we are using overridable APIs.

Technically setProperty can trigger an error naturally if invoked on a readonly style, but I don't think that should ever be the case for us.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150527/8873a531/attachment.html>