[Webkit-unassigned] [Bug 143164] Web Inspector: REGRESSION(r179286) Editing Style Metrics Values no longer works

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143164

Brian Burg <burg at cs.washington.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253801|review?                     |review+
              Flags|                            |

--- Comment #3 from Brian Burg <burg at cs.washington.edu> ---
Comment on attachment 253801
  --> https://bugs.webkit.org/attachment.cgi?id=253801
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253801&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js:425
> +            function didToggle()

Reading the callback code, this will get called even if there was an error in the backend (passed: error, result, wasThrown). Should it only update if something actually changed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150527/3e3522f8/attachment-0001.html>