[Webkit-unassigned] [Bug 90906] Implement ECMAScript Internationalization API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90906

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253565|review?                     |review-
              Flags|                            |

--- Comment #15 from Benjamin Poulain <benjamin at webkit.org> ---
Comment on attachment 253565
  --> https://bugs.webkit.org/attachment.cgi?id=253565
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253565&action=review

r- for the CMakeLists.txt. No real complain otherwise.

> Source/JavaScriptCore/ChangeLog:9
> +        Started work on implementing the Internationaization APIs by adding the feature flag
> +        (disabled until ready), and adding a global Intl object to serve as the namespace.

It would be good to provide a link to the spec here for reference.

> Source/JavaScriptCore/ChangeLog:16
> +        * runtime/JSGlobalObject.cpp:

There is one more build file that needs to know about JSGlobalObject.cpp: Source/JavaScriptCore/CMakeLists.txt

CMake is used for GTK, EFL, and some Windows variant.

> Source/WTF/ChangeLog:9
> +        Started work on implementing the Internationaization APIs by adding the feature flag
> +        (disabled until ready), and adding a global Intl object to serve as the namespace.

You don't need to repeat yourself in each changelog.

Each file has the description for the changes in their particular subpart of the project.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150522/ef99ebaf/attachment.html>