[Webkit-unassigned] [Bug 142786] [GTK] webkit_web_extension_initialize[_with_user_data] not documented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142786

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #16 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Marcos's sentence is better. You could say "To provide initialization data to the function" instead, but Marcos's version is more clear. I would not say "To provide the initialization data used to the function."

A few comments:

"It allows you to execute code in the WebProcess and being able to use the DOM API, to change any request or to inject custom JavaScript code, for example." Since you started off a list of items that begin with "to," the rest of the items should work following "to" as well; in particular, the tense change "being able" is out of place. I don't know what the fancy grammar rule for that is (in school I was taught "parallelism," but the Internet thinks that is something different). There are many different ways to fix this, e.g. "It allows you to execute code in the web process; for example, you can use the DOM API, modify HTTP requests, or inject custom JavaScript."

"GTK module" -> "GTK+ module"

Add the word "process" after "in case you need to initilize the extension with some data from the UI"

"These functions types" -> "These functions' types" since this is possessive. Later in this sentence, add a comma before "respectively," and then one more after "In addition" in the next sentence.

"This function must be called as soon as posible in our app and before any WebProcess is launched." I would say "This function must be called as soon as posible in our app, before any WebProcess is launched."

I could nitpick quite a bit more, but I don't think there's value in that. The English is pretty good. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150520/f7f25ed9/attachment-0001.html>