[Webkit-unassigned] [Bug 145190] New: Web Inspector: Improve TypedArray view in console - show non-index properties (buffer)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145190

            Bug ID: 145190
           Summary: Web Inspector: Improve TypedArray view in console -
                    show non-index properties (buffer)
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: joepeck at webkit.org
                CC: graouts at webkit.org, joepeck at webkit.org,
                    jonowells at apple.com, mattbaker at apple.com,
                    nvasilyev at apple.com, timothy at apple.com,
                    webkit-bug-importer at group.apple.com

* SUMMARY
Improve TypedArray view in console - show non-index properties (buffer, byteLength, byteOffset).

* TEST
var buffer = new ArrayBuffer(12);
var dataView = new DataView(buffer);
var int8View = new Int8Array(buffer);
console.log(buffer);
console.log(dataView);
console.log(int8View); // <---

We treat the TypedArrays, like Int8Array here, as arrays.

In previews we may ignore non-index properties. But even when expanding (console.dir(int8View)) we only show the indices and don't show the buffer/byteLength/byteOffset value properties which may be useful.


* NOTES
- InjectedScriptSource.js possible changes to mark as non-lossy.

    // For arrays, only allow indexes. Mark as lossy if there are non-obvious value properties.
    if (this.subtype === "array" && !isUInt32(name)) {
        if (name !== "length" && name !== "constructor" && descriptor.isOwn && !descriptor.symbol && "value" in descriptor && typeof descriptor.value !== "function")
            preview.lossless = false;
        continue;
    }

- Would still require frontend changes for an ObjectTree for "array" subtype to also show non-index properties. Perhaps in a new section beneath the #s, but before the Prototype.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150519/a09c67be/attachment.html>