[Webkit-unassigned] [Bug 142966] Optimize typed array access with a masked index

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142966

--- Comment #5 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 249236
  --> https://bugs.webkit.org/attachment.cgi?id=249236
Optimize away bounds checks when given masked typed array indexes

View in context: https://bugs.webkit.org/attachment.cgi?id=249236&action=review

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:57
> +        JSValue shiftValue = indexNode->child2().node()->value.value();

It is an antipattern to access the abstract value of a node directly.  You should use AbstractInterpreter::forNode(node).  Also, we usually access the inferred constant value using m_value, not value().

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:68
> +        JSValue offsetValue = indexNode->child2().node()->value.value();

Ditto.

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:93
> +    JSValue maskValue = indexNode->child2().node()->value.value();

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150519/b12e4915/attachment.html>