[Webkit-unassigned] [Bug 144682] Network Cache: Layout Test http/tests/xmlhttprequest/range-test.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144682

Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253328|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 253328
  --> https://bugs.webkit.org/attachment.cgi?id=253328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253328&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:112
> +    String range = request.httpHeaderField(WebCore::HTTPHeaderName::Range);

You could add a FIXME comment that explains that this implements minimal Range support where we don't parse the ranges and only the same exact range request will be served from the cache.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:114
> +    if (range.isEmpty())
> +        range = ASCIILiteral("No range");

You should fix hashString() in NetworkCacheKey.cpp to work with null strings instead. if (string.isNull()) return should be sufficient.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:243
> +    case 206: // Partial Content
>      case 204: // No Content

Please keep these in order.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150519/dcb724c3/attachment.html>