[Webkit-unassigned] [Bug 143768] [W32][GTK] Conflict between NO_ERROR from W32API and GraphicsContext3D

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143768

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250842|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 250842
  --> https://bugs.webkit.org/attachment.cgi?id=250842
Work around name conflicts (NO_ERROR)

View in context: https://bugs.webkit.org/attachment.cgi?id=250842&action=review

I don't understand why the workaround needs to be duplicated, but LRN confirmed it doesn't build otherwise.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:88
> +#if PLATFORM(WIN) || (PLATFORM(QT) && OS(WINDOWS)) || (PLATFORM(GTK) && OS(WINDOWS))

I'll remove the QT thing before landing

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150519/fddf533a/attachment.html>