[Webkit-unassigned] [Bug 144926] Controls should drop off when video gets smaller

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144926

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253036|review?                     |review+
              Flags|                            |

--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 253036
  --> https://bugs.webkit.org/attachment.cgi?id=253036
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253036&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:52
> +Controller.PlayButtonWidth = 44;
> +Controller.RewindButtonWidth = 32;
> +Controller.MuteButtonWidth = 30;
> +Controller.WirelessTargetPickerButtonWidth = 32;
> +Controller.CaptionButtonWidth = 32;
> +Controller.FullScreenButtonWidth = 30;
> +Controller.MinimumTimelineWidth = 200;

It seems really inflexible to hard-wire all these widths. Is there any alternative?

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:626
>              this.controls.statusDisplay.innerText = this.UIString('Error');
> -        else if (this.isLive && this.video.readyState >= HTMLMediaElement.HAVE_CURRENT_DATA)
> +            this.minimumStatusWidth = 50;

It looks like the width here of 50 is based on the width of the string; what if the localized version is wider?

By the way, I think we should use textContent instead of innerText because I believe it is more efficient.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:629
>              this.controls.statusDisplay.innerText = this.UIString('Live Broadcast');
> -        else if (this.video.networkState === HTMLMediaElement.NETWORK_LOADING)
> +            this.minimumStatusWidth = 100;

It looks like the width here of 100 is based on the width of the string; what if the localized version is wider?

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:632
>              this.controls.statusDisplay.innerText = this.UIString('Loading');
> -        else
> +            this.minimumStatusWidth = 75;

It looks like the width here of 75 is based on the width of the string; what if the localized version is wider?

> Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:369
> -        CGContextSetFontAntialiasingStyle(cgContext, kCGFontAntialiasingStyleUnfilteredCustomDilation);
> +        CGContextSetFontAntialiasingStyle(cgContext, kCGFontAntialiasingStyleFilteredCustomDilation);

Please don’t land this change as part of this patch!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150517/0e7893eb/attachment.html>