[Webkit-unassigned] [Bug 144682] Network Cache: Layout Test http/tests/xmlhttprequest/range-test.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144682

Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253184|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 253184
  --> https://bugs.webkit.org/attachment.cgi?id=253184
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253184&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:114
> +    if (range.isEmpty())
> +        range = ASCIILiteral("No range");

This is unnecessary, you can just leave the range string empty.

> LayoutTests/platform/gtk/TestExpectations:-2275
> -webkit.org/b/144682 http/tests/xmlhttprequest/range-test.html [ Failure ]

You should also add a specific test for range header. This should easy to do, check the other tests under LayoutTests/http/tests/cache/disk-cache.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150515/90de2050/attachment-0001.html>