[Webkit-unassigned] [Bug 144738] REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144738

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253103|review?                     |review-
              Flags|                            |

--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 253103
  --> https://bugs.webkit.org/attachment.cgi?id=253103
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253103&action=review

> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:-210
> +    if (m_handle && !m_didConvertHandleToDownload)
>          m_handle->setClient(nullptr);
> -        m_handle = nullptr;
> -    }

This is not right for Mac. On the Mac, the download is not a ResourceHandleClient, so the client pointer is invalid once the handle is converted to a download.

Would it be possible to follow Mac design, and not use a ResourceHandleClient for downloading? This is quite confusing, I certainly didn't expect such a difference when making the change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150514/b7c8994e/attachment.html>