[Webkit-unassigned] [Bug 144954] Small refactoring before ES6 Arrow function implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 13 16:52:14 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144954

--- Comment #13 from Saam Barati <saambarati1 at gmail.com> ---
Comment on attachment 253059
  --> https://bugs.webkit.org/attachment.cgi?id=253059
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253059&action=review

> Source/JavaScriptCore/parser/Parser.cpp:1314
>  {

It's also weird that we we're returning bools and ints from this function.
I think there is probably some case that isn't being thought through.

> Source/JavaScriptCore/parser/Parser.cpp:1363
> +    int parametersStart = parseFunctionParamters(context, requirements, mode, nameIsInContainingScope, functionScope, info);

You might need to propagate errors here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150513/cd5b677b/attachment.html>


More information about the webkit-unassigned mailing list