[Webkit-unassigned] [Bug 144628] [Curl] WebSocket platform part is not implemented.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 13 12:20:23 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144628

--- Comment #20 from peavo at outlook.com ---
(In reply to comment #19)
> Comment on attachment 253030 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253030&action=review
> 
> > Source/WebCore/platform/network/curl/SocketStreamHandle.h:92
> > +        SocketData(std::unique_ptr<char[]>&& source, int length)
> > +        {
> > +            data = WTF::move(source);
> > +            size = length;
> > +        }
> 
> Really irritating that we have to do this to work around a bug in MSVC, but
> I’m pretty sure that is indeed what we are doing, working around a bug. Two
> separate related bugs, I guess.
> 

Thanks for reviewing :) I can try to remember to revisit this code when we move to the next MSVC version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150513/fc7d8533/attachment.html>


More information about the webkit-unassigned mailing list