[Webkit-unassigned] [Bug 144934] View scale changes are temporarily lost after restoring a page from the page cache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 12 16:02:17 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144934

--- Comment #1 from Tim Horton <thorton at apple.com> ---
There's a second hilarity here where, once we fix HistoryController to apply the new viewScale when restoring the pageScale, since the Page's m_pageScaleFactor is already updated to the new value, setPageScaleFactor() will bail and fail to update the scale on the tile container layer.

This never mattered before because the scale that HistoryController handed to setPageScaleFactor() was always the same as the scale already applied to the layer that is coming back from the PageCache (which is no longer true).

I've worked around this by notifying the frames of a pageScaleFactor change if either of the scales is now different from what was stored in the history item -- I'm not sure this is the best fix. Alternatively, we could make setPageScaleFactor take a "no really, I mean it" parameter...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150512/87a46901/attachment-0001.html>


More information about the webkit-unassigned mailing list