[Webkit-unassigned] [Bug 144762] Fix internal build configuration issues

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144762

--- Comment #20 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 252889
  --> https://bugs.webkit.org/attachment.cgi?id=252889
Adds Changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=252889&action=review

> Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:31
> -OTHER_LDFLAGS = $(OTHER_LDFLAGS_$(PLATFORM_NAME)) $(ASAN_OTHER_LDFLAGS);
> -OTHER_LDFLAGS_iphoneos = $(inherited) -l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY) -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework QuartzCore -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework Foundation -framework GraphicsServices -framework ImageIO -framework MobileCoreServices -framework UIKit -framework WebCore -framework JavaScriptCore -framework WebKit $(OTHER_LDFLAGS_FONTS);
> -OTHER_LDFLAGS_iphonesimulator = $(OTHER_LDFLAGS_iphoneos);
> +OTHER_LDFLAGS = $(PLATFORM_OTHER_LDFLAGS) $(ASAN_OTHER_LDFLAGS);
> +PLATFORM_OTHER_LDFLAGS[sdk=iphone*] = -l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY) -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework QuartzCore -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework Foundation -framework GraphicsServices -framework ImageIO -framework MobileCoreServices -framework UIKit -framework WebCore -framework JavaScriptCore -framework WebKit $(OTHER_LDFLAGS_FONTS);

OTHER_LDFLAGS should probably include $(inherited) here to match other *.xcconfig files (and to pick up OTHER_LDFLAGS settings prior to this xcconfig file):

OTHER_LDFLAGS = $(inherited) $(PLATFORM_OTHER_LDFLAGS) $(ASAN_OTHER_LDFLAGS);

This can be fixed in a follow-up patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150512/f8608b6b/attachment.html>