[Webkit-unassigned] [Bug 144560] [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144560

--- Comment #10 from Philip Chimento <philip.chimento at gmail.com> ---
(In reply to comment #9)

Thanks, I'll update the patch with these comments.

> Most of those OS(DARWIN) -> PLATFORM(COCOA) changes don’t seem right to me.
> I added comments about a few of them. Others sound comment on the use inside
> WebKit2.
> 
> > Source/WTF/wtf/WorkQueue.h:39
> > -#if OS(DARWIN)
> > +#if PLATFORM(COCOA)
> >  #include <dispatch/dispatch.h>
> >  #endif
> 
> It’s a little sad to go in this direction. Better to use the OS ones than
> the PLATFORM ones whenever possible.

My previous version had #if OS(DARWIN) && !PLATFORM(GTK) everywhere. That works for me as well, but everyone should agree on one and stick with it ;-)

I do prefer Csaba's suggestion of PLATFORM(COCOA) because the way I think of "platform" it should use mainly the same dependencies no matter what OS it's compiled on. For me, differences between the OSs should limit themselves to e.g. system calls (an example of what I mean is https://bugs.webkit.org/show_bug.cgi?id=144554). But, I'm happy to go either way with this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150512/81760e70/attachment-0001.html>