[Webkit-unassigned] [Bug 144628] [Curl] WebSocket platform part is not implemented.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144628

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252878|review?                     |review+
              Flags|                            |

--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 252878
  --> https://bugs.webkit.org/attachment.cgi?id=252878
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252878&action=review

> Source/WebCore/platform/network/curl/SocketStreamHandle.h:77
> +    std::unique_ptr<const char[]> createCopy(const char* data, int length);

Should be static.

> Source/WebCore/platform/network/curl/SocketStreamHandle.h:99
> +        SocketData(std::unique_ptr<const char[]>&& source, int length)
> +        {
> +            data = WTF::move(source);
> +            size = length;
> +        }
> +
> +        SocketData(SocketData&& other)
> +        {
> +            data = WTF::move(other.data);
> +            size = other.size;
> +            other.size = 0;
> +        }

I don’t understand why you had to define these.

> Source/WebCore/platform/network/curl/SocketStreamHandleCurl.cpp:71
> +    m_sendData.append(SocketData(WTF::move(copy), length));

Should just be SocketData { WTF::move(copy), length } and then it should work without a constructor.

> Source/WebCore/platform/network/curl/SocketStreamHandleCurl.cpp:215
> +            if (refCount() > 1)
> +                didOpenSocket();

Needs a comment explaining why it’s here. Something like how you replied to my query about this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150512/9e65ac97/attachment.html>