[Webkit-unassigned] [Bug 139757] Delegates scrolling by wheel event should be work within contents area.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139757

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252854|review?                     |review-
              Flags|                            |

--- Comment #21 from Darin Adler <darin at apple.com> ---
Comment on attachment 252854
  --> https://bugs.webkit.org/attachment.cgi?id=252854
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252854&action=review

review- because skipping this test on Mac only isn’t right. But we can’t see that problem with EWS because currently only Mac EWS runs tests, so skipping on Mac is enough to make EWS happy.

Someone needs to test this on iOS to see that it works as expected there. Could cause problems there because the scrolling UI involves rubber banding; this might interfere with that, maybe not.

> LayoutTests/platform/mac/TestExpectations:287
> +# This port doesn't support delegate scrolling
> +fast/events/scroll-delegates-wheelevent.html [ WontFix ]

This doesn’t seem right. Mac is not the only port that has this issue. It’s just that the EWS bot only runs the test on Mac. So skipping this only for Mac is incorrect. I bet this also doesn’t work on Windows, and perhaps some other platforms as well.

As far as I can tell, the “delegates scrolling” code path is used on iOS, and on platforms that use WebKit2 with COORDINATED_GRAPHICS. We shouldn’t be testing it on any other platforms unless we expect it to work.

So just skipping this on Mac is not right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150511/7a349ad0/attachment.html>