[Webkit-unassigned] [Bug 144845] [CMake] Some macros need to be defined/undefined, rather than ON/OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144845

--- Comment #5 from Philip Chimento <philip.chimento at gmail.com> ---
(In reply to comment #3)
> Thanks for your patches. I'd like to change the code to be more robust to
> this, checking values rather than definitions. But I don't see value in
> fighting that fight in npapi.h, so this is probably the best approach. Let's
> see what Martin thinks. There should for sure be a warning comment, though,
> or someone will revert this patch in passing as a cleanup.

Sure thing. I did kind of assume that npapi.h was off limits. I've added a warning comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150510/133cd528/attachment.html>