[Webkit-unassigned] [Bug 144848] New: Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144848

            Bug ID: 144848
           Summary: Introduce UniquedStringImpl and SymbolImpl to separate
                    symbolic strings from AtomicStringImpl
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: utatane.tea at gmail.com

The current AtomicStringImpl accidentally means the symbol OR atomic StringImpl.
It's not correct to its name and it's error prone.

In this issue, we'll introduce new 2 classes into WTF.

1. UniquedStringImpl

It's derived class from StringImpl. And it represents symbol || atomic StringImpl.
Since it contains symbol string, prohibiting the operator== for the other strings is preferable I think.
Only pointer based comparison is accepted. (due to its uniqueness)

2. SymbolImpl

It's derived class from UniquedStringImpl. Only symbol strings can become this.
It ensures the given StringImpl is symbol in compile time.


And changing AtomicStringImpl.

3. AtomicStringImpl

It's derived class from UniquedStringImpl. Only atomic (non-normal && non-symbol) strings can become this.
It ensures the given StringImpl is atomic in compile time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150510/20bf738a/attachment-0001.html>