[Webkit-unassigned] [Bug 144836] Use preview view controller from WebKitSystemInterface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144836

mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252821|review?                     |review+
              Flags|                            |

--- Comment #5 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 252821
  --> https://bugs.webkit.org/attachment.cgi?id=252821
New patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=252821&action=review

> Source/WebKit2/ChangeLog:23
> +        (-[WKContentView previewViewControllerForPosition:inSourceView:]): : For client that doesn't provide

: :

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:131
> + at property (nonatomic, getter=_allowsLinkPreview, setter=_setAllowsLinkPreview:) BOOL _allowsLinkPreview;

No need for a custom getter here since it’s the same as the property name. Needs WK_AVAILABLE(NA, WK_IOS_TBA).

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:211
> +
> +- (void)_registerPreviewInWindow:(UIWindow *)window;
> +- (void)_unregisterPreviewInWindow:(UIWindow *)window;

Weird to have a newline before but not after.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150510/ebfd4a68/attachment.html>