[Webkit-unassigned] [Bug 144836] Use preview view controller from WebKitSystemInterface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144836

--- Comment #3 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 252791
  --> https://bugs.webkit.org/attachment.cgi?id=252791
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=252791&action=review

This looks OK to me. I am surprised that the new property is being introduced as API right away rather than SPI. I’d like someone else from Apple to review this aspect.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:235
> + at property (nonatomic) BOOL allowsLinkPreview;

This needs WK_AVAILABLE(NA, WK_IOS_TBA).

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:45
> +#if USE(APPLE_INTERNAL_SDK)
> +#import <WebKitAdditions/LinkPreviewDefines.h>
> +#endif

These lines should move  to a separate paragraph, after the non-conditional imports.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3116
> +    _previewGestureRecognizer.clear();

We seem to prefer “= nil” to clear().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150510/a6f75881/attachment.html>