[Webkit-unassigned] [Bug 144788] [GTK] WTR doesn't correctly handle the Escape key

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144788

--- Comment #11 from Martin Robinson <mrobinson at webkit.org> ---
(In reply to comment #10)

> > For an example of an uncertainty with the escape key approach: if we send
> > the key between tests, will it pollute the results of tests before and after
> > it? I'm not sure, but I do know that the gtk_menu_popdown approach works
> > without a hitch.
> 
> I don't send Escape between tests, but after running the context menu.

Let me explain then: At times the context menus remains popped up between tests, as well as after context click. This is a problem because, as you know, context menus maintain grabs which block events to the web view. These are two issues between tests and between different calls to send an event from the test harness. I think a good fix would be to never actually pop up context menus in the first place, but that could be more involved. The reason we need to handle this between tests is that not all tests dismiss their context menus, and context menus don't disappear between page loads (you can verify this by test it in minibrowser).

There are many tests that do not dismiss the context menu explicitly. For instance look at editing/spelling/context-menu-suggestions.html.

Your escape key approach looks interesting, but really the escape key is just going to call gtk_menu_popdown, so I prefer to just do that directly. The reason is that the test harness is basically a machine that eats key events and poops out test expectations. I feel nervous sending it another key event, after again spending hours, running layout tests and looking at results. 

> I don't like that patch that much, TBH. I won't oppose it if there isn't a better alternative, though.

Would you please go to the patch and articulate your concerns? Just blocking it without reason or because you have an untested idea is incredibly frustrating. I'd like to move on from this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150508/553e746a/attachment.html>