[Webkit-unassigned] [Bug 144788] [GTK] WTR doesn't correctly handle the Escape key

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144788

--- Comment #8 from Martin Robinson <mrobinson at webkit.org> ---
(In reply to comment #7)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Once my original patch lands, I can run layout tests with this patch as well
> > > and report back.
> > 
> > Ideally, this patch blocks #40601, because with this, your patch might be
> > reduced to a one line :-)
> 
> I spent quite a few tedious hours running the tests and generating results,
> so I'd much prefer to just land my original patch and then go back and
> improve it later. It will be simpler for me and I won't have to worry about
> going down a rat hole. I promise that I will try out your escape key
> approach, which looks promising and propose another patch if it works.

For an example of an uncertainty with the escape key approach: if we send the key between tests, will it pollute the results of tests before and after it? I'm not sure, but I do know that the gtk_menu_popdown approach works without a hitch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150508/a989837f/attachment.html>