[Webkit-unassigned] [Bug 144739] Fix sizes crash and add invalid value tests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 7 13:37:44 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144739

Yoav Weiss <yoav at yoav.ws> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252614|review?                     |commit-queue+
              Flags|                            |

--- Comment #5 from Yoav Weiss <yoav at yoav.ws> ---
Comment on attachment 252614
  --> https://bugs.webkit.org/attachment.cgi?id=252614
Patch

I've refactored the code so that it would be more straight forward.

The length check has to happen only after we know we have a CSSPrimitiveLength on our hands, to it has to happen in the loop, but only happens on the first matching expression (in case it is in fact a CSSPrimitiveValue). We also need to maintain a single loop for both lengths and calcs, since the algorithm is a first-match.

Regarding the creation of CSSPrimitiveValue just to calculate length, that is a shame. I'll try to refactor out the computeLength logic of CSSPrimitiveValue to be static, so that it can be used here without creating a new object. I'll do that as a separate issue though, since I suspect it may be a large patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150507/d41f0b20/attachment.html>


More information about the webkit-unassigned mailing list