[Webkit-unassigned] [Bug 144663] New force-related DOM events should fire in WK1 views

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144663

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252540|review?                     |review+
              Flags|                            |

--- Comment #15 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 252540
  --> https://bugs.webkit.org/attachment.cgi?id=252540
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252540&action=review

> Source/WebCore/page/mac/EventHandlerMac.mm:124
>      currentNSEventSlot() = m_savedCurrentEvent;
> +    correspondingPressureEventSlot() = nil;

I would follow the pattern we have here and keep a stack of corresponding events.

> Source/WebKit/mac/WebView/WebHTMLView.mm:4093
> +    NSEvent *lastPressureEvent = [[self _webView] _pressureEvent];
> +    if (event == lastPressureEvent)
> +        return;

Is this necessary? It seems like it can't happen.

> Source/WebKit/mac/WebView/WebViewData.h:178
> +    NSEvent *pressureEvent;

This should be a RetainPtr. You can probably get rid of the helpers when you make this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150507/6ce30379/attachment-0001.html>