[Webkit-unassigned] [Bug 144700] Media Controls: Scrubber should not follow actual video time, causes scrubber to be jumpy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144700

--- Comment #9 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 252597
  --> https://bugs.webkit.org/attachment.cgi?id=252597
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252597&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:888
>      handleTimelineMouseMove: function(event)
>      {
> +        this.updateControlsWhileScrubbing();
> +

Shouldn't this be handled in handleTimelineInput()?  (And in handleTimelineChange())? Doing it this way means that the controls won't update when the timeline is changed through Accessibility.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1408
> +        
> +        if (this.isWaitingForBuffer)
> +            return;

Why is this necessary? Surely we're not getting "timechange" events when we're in the "waiting" state.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150507/cd6ab7e9/attachment.html>