[Webkit-unassigned] [Bug 144746] [GTK] 2.9.1 build broken with ENABLE_MINIBROWSER=ON

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 7 09:18:47 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144746

--- Comment #1 from Michael Catanzaro <mcatanzaro at igalia.com> ---
#if defined(DEVELOPMENT_BUILD)
    g_setenv("WEBKIT_INJECTED_BUNDLE_PATH", WEBKIT_INJECTED_BUNDLE_PATH, FALSE);
#endif

The problem is that WEBKIT_INJECTED_BUNDLE_PATH is only defined when DEVELOPMENT_BUILD is on. Previously DEVELOPMENT_BUILD was defined only for development builds, but now it is defined to 0 when off (using the new SET_AND_EXPOSE_TO_BUILD macro).

Possible fixes:

#if DEVELOPMENT_BUILD
    g_setenv("WEBKIT_INJECTED_BUNDLE_PATH", WEBKIT_INJECTED_BUNDLE_PATH, FALSE);
#endif

or:

#ifdef WEBKIT_INJECTED_BUNDLE_PATH
    g_setenv("WEBKIT_INJECTED_BUNDLE_PATH", WEBKIT_INJECTED_BUNDLE_PATH, FALSE);
#endif

The later seems best to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150507/85885f07/attachment.html>


More information about the webkit-unassigned mailing list