[Webkit-unassigned] [Bug 144521] [X11] Add XUniquePtr and XUniqueResource to automatically free X resources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144521

--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #11)
> Comment on attachment 252487 [details]
> Try to fix EFL build
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252487&action=review
> 
> >>> Source/WebCore/PlatformEfl.cmake:200
> >>> +    platform/graphics/x11/XUnique.cpp
> >> 
> >> Consider splitting XUnique.h into XUniquePtr.h and XUniqueResource.h, and renaming XUnique.cpp to XUniqueResource.cpp.
> > 
> > Why? I think it's quite simple and reduces the amount of header includes.
> 
> Because over the lifetime of the WebKit project we’ve found that using a
> separate header for each class is a better pattern. Headers that have sets
> of classes might make sense when you are writing the code, but they can be
> frustrating later when reading and maintaining the code; a more mechanical
> rule is easier to understand and works better for someone who thinks
> slightly differently than the original author about categories.

Fair enough!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150507/d00424f9/attachment.html>