[Webkit-unassigned] [Bug 144663] New force-related DOM events should fire in WK1 views

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144663

--- Comment #10 from Tim Horton <thorton at apple.com> ---
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Comment on attachment 252527 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=252527&action=review
> > > 
> > > > Source/WebCore/page/mac/EventHandlerMac.mm:86
> > > > +    static NeverDestroyed<RetainPtr<NSEvent>> event;
> > > 
> > > Is it really right for this to be stored between views? That seems weird.
> > > 
> > 
> > Hmm, maybe not. I was copying what's done for currentNSEventSlot(). I think
> > it makes as much sense in this new case as it did in the old, but I'm a
> > little unsure here.
> 
> It's OK to keep a "current" event globally, because the relevant parts of
> WebKit are single-threaded, and a "current" event will get cleared when it's
> done (I assume). But keeping a "last" event, that lives beyond its own
> handling, seems wrong in the multi-view case.

OK, Sam explained that this *is* actually the force event matching the currently processing event, not actually the last event, and it doesn't persist between handling events, so I think it just needs a different name, not a big change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150506/51cb0f0e/attachment.html>