[Webkit-unassigned] [Bug 144663] New force-related DOM events should fire in WK1 views

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144663

--- Comment #8 from Tim Horton <thorton at apple.com> ---
(In reply to comment #6)
> (In reply to comment #5)
> > > Source/WebKit/mac/WebView/WebHTMLView.mm:-3844
> > > -    [[[self _webView] _immediateActionController] webView:[self _webView] willHandleMouseDown:event];
> > 
> > Whaaaaaa?
> > 
> 
> This is because mouseDown used to come after the immediate action! Remember?
> We used to have shenanigans like this in WK2 as well, and we were able to
> remove them when we switched to delaysPrimaryMouseEvents:NO. This code was
> there purely because we were getting mouse down at a weird time.

Righto.

> > Could you not keep this in EventHandler instead and avoid keeping it here?
> 
> Hmmmmmmm. I'll have to think this over. This is a closer mirror to what we
> do in WK2. If we moved it to EventHandler, we would have WK1 only member
> variables there, which we actually manage to avoid at this point.

Could you not then perhaps use them for WK2 as well, and share some code that you currently have duplicated between WebView and WKView?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150506/ea9a4ae2/attachment.html>