[Webkit-unassigned] [Bug 144533] REGRESSION (r183467): Unable to start downloads in private browsing mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144533

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252472|review?                     |review+
              Flags|                            |

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 252472
  --> https://bugs.webkit.org/attachment.cgi?id=252472
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252472&action=review

> Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:334
> +    ResourceLoadPriority oldPriority = priority();
> +    RefPtr<FormData> oldHTTPBody = httpBody();
> +    bool isHiddenFromInspector = hiddenFromInspector();
> +    auto oldRequester = requester();

What makes these the only 4 we need to preserve? I think there should be a comment here explaining the theory of which properties should be listed here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150506/7e73f53c/attachment-0001.html>