[Webkit-unassigned] [Bug 144675] Fix <script srcset> being loaded by the preloader.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 6 09:21:56 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144675

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 252460
  --> https://bugs.webkit.org/attachment.cgi?id=252460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252460&action=review

> LayoutTests/http/tests/loading/preload-script-src-expected.txt:6
> +This test needs to be run in DRT. Preload scanner should see the script resource. 

It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner.

> LayoutTests/http/tests/loading/preload-script-src.html:9
> +This test needs to be run in DRT. Preload scanner should see the script resource.

It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner.

> LayoutTests/http/tests/loading/preload-script-srcset-ignored-expected.txt:6
> +This test needs to be run in DRT. Preload scanner should not see the script resource since it's in a srcset attribute. 

It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner.

> LayoutTests/http/tests/loading/preload-script-srcset-ignored.html:9
> +This test needs to be run in DRT. Preload scanner should not see the script resource since it's in a srcset attribute.

It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150506/9256f322/attachment.html>


More information about the webkit-unassigned mailing list