[Webkit-unassigned] [Bug 144674] Add srcset preloader tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144674

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252457|review?                     |review+
              Flags|                            |

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 252457
  --> https://bugs.webkit.org/attachment.cgi?id=252457
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252457&action=review

> LayoutTests/http/tests/loading/preload-img-src-expected.txt:6
> +This test needs to be run in DRT. Preload scanner should see the image resource. 

It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner.

> LayoutTests/http/tests/loading/preload-img-src.html:9
> +This test needs to be run in DRT. Preload scanner should see the image resource.

It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner.

> LayoutTests/http/tests/loading/preload-img-srcset-expected.txt:6
> +This test needs to be run in DRT. Preload scanner should see the image resource. 

It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner.

> LayoutTests/http/tests/loading/preload-img-srcset-sizes-expected.txt:6
> +This test needs to be run in DRT. Preload scanner should see the image resource. 

It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner.

> LayoutTests/http/tests/loading/preload-img-srcset-sizes.html:9
> +This test needs to be run in DRT. Preload scanner should see the image resource.

It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner.

> LayoutTests/http/tests/loading/preload-img-srcset.html:9
> +This test needs to be run in DRT. Preload scanner should see the image resource.

It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150506/35b9a9c6/attachment-0001.html>