[Webkit-unassigned] [Bug 144685] [EGL] Move EGLDisplay handling to PlatformDisplay and remove PlatformDisplay definition from GLDefs.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144685

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org

--- Comment #5 from Martin Robinson <mrobinson at webkit.org> ---
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 252470 [details]
> > Try to fix EFL build
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=252470&action=review
> > 
> > > Source/WebCore/platform/graphics/PlatformDisplay.cpp:139
> > > +#if USE(OPENGL_ES_2)
> > > +    static const EGLenum eglAPIVersion = EGL_OPENGL_ES_API;
> > > +#else
> > > +    static const EGLenum eglAPIVersion = EGL_OPENGL_API;
> > > +#endif
> > > +    if (eglBindAPI(eglAPIVersion) == EGL_FALSE) {
> > > +        LOG_ERROR("Failed to set EGL API(%d).", eglGetError());
> > > +        terminateEGLDisplay();
> > > +        return;
> > > +    }
> > 
> > This needs to be called once per program, not once per display. Perhaps you
> > could surround this with std::once.
> 
> Display is already a single instance, so this will be called only once per
> display, per process.

eglBindAPI isn't supposed to be called once per-display. I supposed to be called once.

> 
> > > Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.cpp:153
> > > -    m_glxPixmap = glXCreateGLXPixmap(m_sharedDisplay, visualInfo.get(), m_pixmap);
> > > +    m_glxPixmap = glXCreateGLXPixmap(X11Helper::nativeDisplay(), visualInfo.get(), m_pixmap);
> > 
> > This is GLX-related, so perhaps you could update the bug title and ChangeLog
> > slightly?
> 
> But nothing has actually changed here, I can add and remove PlatformDisplay
> from GLDefs.h

I'm not sure I understand what you mean, but the change is so small that you can probably skip mentioning GLX in the ChangeLog if you don't think it matters.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150506/075a5f4e/attachment.html>