[Webkit-unassigned] [Bug 144650] Web Inspector: REGRESSION(Tabs): Issues reloading a resource with breakpoints

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144650

--- Comment #6 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 252441
  --> https://bugs.webkit.org/attachment.cgi?id=252441
[PATCH] Progress

View in context: https://bugs.webkit.org/attachment.cgi?id=252441&action=review

> Source/WebInspectorUI/UserInterface/Views/ContentView.js:124
> +        console.error("Unknown ContentView", representedObject);
> +
>          throw "Can't make a ContentView for an unknown representedObject.";

I've been considering removing the throw here and just doing a console.error.

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:393
> +        for (var i = this._breakpointsContentTreeOutline.children.length - 1; i >= 0; --i) {
> +            var treeElement = this._breakpointsContentTreeOutline.children[i];
> +            if (treeElement !== this._globalBreakpointsFolderTreeElement)
> +                this._breakpointsContentTreeOutline.removeChildAtIndex(i, true, true);
> +        }

You should not need to do this. DebuggerSidebarPanel opts-in to NavigationSidebarPanel's autoPruneOldTopLevelResourceTreeElements. That will remove ResourceTreeElements that go away on MainResourceDidChange, ChildFrameWasRemoved, and ResourceWasRemoved events. The closeAllContentViews is all we should need.

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:429
> +        // FIXME: Is this needed, now that we clear everything on main resource changes?

Yes, since NavigationSidebarPanel does not auto-prune these.

> Source/WebInspectorUI/UserInterface/Views/TabContentView.js:127
> -        var cookie = this._cookieSetting.value || {};
> +        var cookie = {};

Ah, yes. I see how this was wrong now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150506/83b82a7f/attachment.html>