[Webkit-unassigned] [Bug 140855] [ES6] Implement ES6 arrow function syntax

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140855

--- Comment #130 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 252416
  --> https://bugs.webkit.org/attachment.cgi?id=252416
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252416&action=review

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1541
> +#if ENABLE(ES6_ARROWFUNCTION_SYNTAX)

Why do you need this guard?  I recommend adding the arraowFunctionStructure() to JSGlobalObject unconditionally.

> Source/JavaScriptCore/dfg/DFGCapabilities.cpp:234
> +    case op_new_arrow_func_exp: // Fixme: Arrow function cann't be inline as the common function because it has lexicaly bind this/arguments and etc. and  arrow function has to have its own compile and inline approach.

I don't buy this comment at all.  Sounds like either there is a horrible bug, or you could just allow it.

> Source/JavaScriptCore/dfg/DFGStructureRegistrationPhase.cpp:134
> +#if ENABLE(ES6_ARROWFUNCTION_SYNTAX)

Ditto to my previous.  Get rid of this guard.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2992
> +    void compileNewArrowFunction()

If you're going to implement it in the FTL, then also implement it in DFG.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150505/0d5eb413/attachment.html>