[Webkit-unassigned] [Bug 144613] New: [CMake] FindGTK3.cmake should not modify the values of build options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144613

            Bug ID: 144613
           Summary: [CMake] FindGTK3.cmake should not modify the values of
                    build options
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

FindGTK3.cmake touches both ENABLE_X11_TARGET and ENABLE_WAYLAND_TARGET currently. I didn't realize it was doing that (since it is just a find module and I didn't anticipate it having side effects). Anyway, that won't work as expected anymore since this code runs after the values of those settings have already gone into the FEATURE_DEFINES list, so you would wind up with e.g. ENABLE_X11_TARGET turned off for most of the build, but on in other places (like IDL files).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150505/f6b34dd0/attachment.html>