[Webkit-unassigned] [Bug 140855] [ES6] Implement ES6 arrow function syntax

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140855

--- Comment #123 from GSkachkov <gskachkov at gmail.com> ---
(In reply to comment #109)
> Comment on attachment 251129 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251129&action=review
> 
> > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:3755
> > +#if ENABLE(ES6_ARROWFUNCTION_SYNTAX)
> > +        case op_new_arrow_func_exp: {
> > +            FunctionExecutable* expr = m_inlineStackTop->m_profiledBlock->functionExpr(currentInstruction[3].u.operand);
> > +            FrozenValue* frozen = m_graph.freezeStrong(expr);
> > +            set(VirtualRegister(currentInstruction[1].u.operand),
> > +                addToGraph(NewFunction, OpInfo(frozen), get(VirtualRegister(currentInstruction[2].u.operand))));
> > +            NEXT_OPCODE(op_new_arrow_func_exp);
> > +        }
> > +#endif
> 
> This looks like it has to be wrong since you're not using operand 4.

Thanks for review. Comment is fixed in new patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150503/aa3c545f/attachment.html>