[Webkit-unassigned] [Bug 144517] [GTK][EFL] Unify platform display handling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 3 04:43:35 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144517

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #5)
> Comment on attachment 252223 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252223&action=review
> 
> > Source/WebCore/platform/graphics/PlatformDisplay.cpp:49
> > +PlatformDisplay* PlatformDisplay::createPlatformDisplay()
> 
> Any reason why this doesn't use std::make_unique<>() and return a
> std::unique_ptr<>?

Not really, I changed that several times, it was initially a reference until I realized it could return nullptr.

> > Source/WebCore/platform/graphics/PlatformDisplay.cpp:77
> > +std::unique_ptr<PlatformDisplay> PlatformDisplay::s_sharedDisplay;
> 
> I'd prefer this moved off the class and into the
> PlatformDisplay::sharedDisplay() method.
> Perhaps it would be wise to also use std::call_once(), given that in the
> future this might be accessed from multiple threads.

Sure, very good points, I'll update the patch. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150503/b3d0517f/attachment.html>


More information about the webkit-unassigned mailing list