[Webkit-unassigned] [Bug 144517] [GTK][EFL] Unify platform display handling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144517

--- Comment #5 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 252223
  --> https://bugs.webkit.org/attachment.cgi?id=252223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252223&action=review

> Source/WebCore/platform/graphics/PlatformDisplay.cpp:49
> +PlatformDisplay* PlatformDisplay::createPlatformDisplay()

Any reason why this doesn't use std::make_unique<>() and return a std::unique_ptr<>?

> Source/WebCore/platform/graphics/PlatformDisplay.cpp:77
> +std::unique_ptr<PlatformDisplay> PlatformDisplay::s_sharedDisplay;

I'd prefer this moved off the class and into the PlatformDisplay::sharedDisplay() method.
Perhaps it would be wise to also use std::call_once(), given that in the future this might be accessed from multiple threads.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150503/ee24f452/attachment.html>